Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added op mainnet into the Ocean market #2007

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Added op mainnet into the Ocean market #2007

merged 4 commits into from
Nov 29, 2023

Conversation

LoznianuAnamaria
Copy link
Contributor

@LoznianuAnamaria LoznianuAnamaria commented Nov 28, 2023 •
edited by bogdanfazakas
Loading

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 11:25am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 11:25am

@LoznianuAnamaria LoznianuAnamaria marked this pull request as ready for review November 28, 2023 16:53
bogdanfazakas
bogdanfazakas approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job @AnaLoznianu 👍

@LoznianuAnamaria
Copy link
Contributor Author

Thank you 👌

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit 422c43b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 60.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

@LoznianuAnamaria LoznianuAnamaria merged commit 1e09614 into main Nov 29, 2023
15 checks passed
@LoznianuAnamaria LoznianuAnamaria deleted the feature/optimism branch November 29, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoznianuAnamaria @bogdanfazakas